blue-oil/blueoil

refactor train.py

Open

#481 opened on Oct 2, 2019

View on GitHub
 (4 comments) (2 reactions) (1 assignee)Python (250 stars) (85 forks)batch import
good first issue

Description

The function start_training in train.py is too long, it should be decomposed into some functions.

It might be better to add a new class Trainer?

Contributor guide

Tech stack
python
Domain
backendmachine learning
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonOOP concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the `train.py` file, specifically the `start training` function. The issue suggests decomposing it into smaller functions and possibly creating a `Trainer` class. Review the 4 existing comments for additional context and any proposed approaches. Consider the existing class structure and how the new `Trainer` class would integrate. Check the assigned user's activity to see if there is an open branch or progress.