blue-oil/blueoil

View class in dlk should be merge into Operator classes

Open

#478 opened on Oct 2, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (85 forks)batch import
good first issue

Repository metrics

Stars
 (250 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

View.run method in view.py is quite long. It is actually just returning stringified C++ source code for each operator. Hence, it looks very natural to decompose this method and merge the pieces into each corresponding operators implementation in operator.py.

After the merge, we will be able to remove View class.

Contributor guide

Research direction
Examine the View.run method and the Operator classes, then move the string generation code into each operator's implementation.
Tech stack
python
Domain
backendmachine learning
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70