blue-oil/blueoil

View class in dlk should be merge into Operator classes

Open

#478 opened on Oct 2, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (250 stars) (85 forks)batch import
good first issue

Description

View.run method in view.py is quite long. It is actually just returning stringified C++ source code for each operator. Hence, it looks very natural to decompose this method and merge the pieces into each corresponding operators implementation in operator.py.

After the merge, we will be able to remove View class.

Contributor guide

Tech stack
python
Domain
backendmachine learning
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Python programmingfamiliarity with blueoil codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue aims to refactor the View class in view.py by decomposing its run method and merging the pieces into the corresponding operator implementations in operator.py. After the merge, the View class can be removed. The contributor should study the View.run method to understand how it generates C++ source code for each operator, then move that logic into the respective operator classes. This involves code reorganization and ensuring no functionality is broken.