blu3-bird/Shopping-on-tuesday

[Bug] Incorrect exception handling in admin routes

Open

#47 opened on Dec 10, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)CSS (16 forks)auto 404
frontendhelp wantedinvalid🐕bug🐭good first issue🫎enhancement

Repository metrics

Stars
 (5 stars)
PR merge metrics
 (PR metrics pending)

Description

[Bug] Incorrect exception handling in admin routes

Problem

app/admin/routes.py - Exception handling issues:

except (DataError, SQLAlchemyError, OperationalError, IntegrityError) as e:

SQLAlchemyError is parent class, others are redundant

-Exception variable e unused (no logging) -Repeated in add_product, edit_product, delete_product

Fix Needed

-Use only SQLAlchemyError -Add error logging with exception details Labels: bug, error-handling

Contributor guide

Research direction
Replace the redundant exception classes (DataError, OperationalError, IntegrityError) with only SQLAlchemyError and add error logging using logging.exception(e) in each catch block in app/admin/routes.py.
Tech stack
pythonflask
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonFlaskSQLAlchemy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80