blu3-bird/Shopping-on-tuesday

Replace hard-coded route strings with constants in auth/routes.py

Open

#46 opened on Dec 10, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)CSS (16 forks)auto 404
documentationfrontendhelp wanted🐭good first issue🫎enhancement

Repository metrics

Stars
 (5 stars)
PR merge metrics
 (PR metrics pending)

Description

[Refactor] Replace hard-coded route strings with constants in auth/routes.py

Description

The authentication routes file (app/auth/routes.py) contains hard-coded route name strings that should be replaced with constants for better maintainability.

Current Issues

File: app/auth/routes.py

Hard-coded strings found:

  • 'admin.dashboard' (appears 2 times in login function)
  • 'main.index' (appears 1 time in logout function)
  • 'auth.login' (appears 1 time in login function)

Problems

  • Typos only caught at runtime
  • Difficult to refactor if route names change

Reference

  • DEFAULT_AFTER_LOGIN = 'admin.dashboard'
  • DEFAULT_AFTER_LOGOUT = 'main.index'

Labels: enhancement, refactoring, code-quality Scope: app/auth/routes.py

Contributor guide

Research direction
Open app/auth/routes.py and replace the hard coded route strings 'admin.dashboard', 'main.index', and 'auth.login' with constants. Look for a constants file or module that defines these (e.g., DEFAULT AFTER LOGIN, DEFAULT AFTER LOGOUT) and import them. Test that the routes still work after the change.
Tech stack
pythonflask
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonFlaskGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90