bloomberg/goldpinger

Add TCP checks on top of HTTP checks

Open

#47 opened on Jan 23, 2019

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (2,316 stars) (186 forks)batch import
enhancementgood first issuehelp wanted

Description

I've been trying Goldpinger out recently, and have been finding it useful already. I was looking through the code, and was curious why you chose to do http monitoring, rather than tcp or icmp pings?

Contributor guide

Tech stack
gokubernetes
Domain
infrastructureobservability
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingKubernetes basicsNetwork protocols
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the existing HTTP check implementation in the codebase (likely in a file like 'pkg/checker/http.go'). Understand the architecture of Goldpinger's checker interface. Propose a design for TCP check that follows the same pattern. Consider edge cases like connection timeouts and errors. The issue contains discussion about the rationale; read through comments for additional context. Avoid making changes before maintainer feedback.