blakeembrey/code-problems

Broken tests?

Open

#118 opened on Jun 3, 2014

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (3,818 stars) (586 forks)batch import
help wanted

Description

TDD is something I have to take a deeper look, but the tests at least for python are broken. It failed because the test can't find the methods used, which is normal because they aren't imported.

python largest-continuous-sum.py
E
======================================================================
ERROR: test_largest_continuous_sum (__main__.LargestContinousSequenceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "largest-continuous-sum.py", line 5, in test_largest_continuous_sum
    sum = largest_continuous_sum([1, 2, 3, 4])
NameError: global name 'largest_continuous_sum' is not defined

----------------------------------------------------------------------
Ran 1 test in 0.000s

As this is not a package, how we should accomplish this?

Contributor guide

Tech stack
python
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Pythontesting knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
The issue points to the file 'largest continuous sum.py' in the repository 'blakeembrey/code problems'. The test method 'test largest continuous sum' fails because 'largest continuous sum' is not defined or imported. The fix is to import or define the function 'largest continuous sum' in the test file. Check if there is a separate implementation file and import it, or define the function in the same file.