blakeembrey/code-problems

Broken tests?

Open

#118 opened on Jun 3, 2014

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (586 forks)batch import
help wanted

Repository metrics

Stars
 (3,818 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

TDD is something I have to take a deeper look, but the tests at least for python are broken. It failed because the test can't find the methods used, which is normal because they aren't imported.

python largest-continuous-sum.py
E
======================================================================
ERROR: test_largest_continuous_sum (__main__.LargestContinousSequenceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "largest-continuous-sum.py", line 5, in test_largest_continuous_sum
    sum = largest_continuous_sum([1, 2, 3, 4])
NameError: global name 'largest_continuous_sum' is not defined

----------------------------------------------------------------------
Ran 1 test in 0.000s

As this is not a package, how we should accomplish this?

Contributor guide

Research direction
Add the missing import statement for the function being tested or define it in the test file.
Tech stack
python
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80