bitwarden/server

Emergency Access E-Mails use Wrong Encoding for Names

Open

#4,845 opened on Oct 3, 2024

View on GitHub
 (3 comments) (1 reaction) (0 assignees)C# (18,588 stars) (1,575 forks)batch import
buggood first issue

Description

Steps To Reproduce

  1. Configure a name for your account using special characters like a German umlaut
  2. Invite someone for emergency access
  3. Confirm the invatation on both sides

Expected Result

The e-mails should display the special characters correctly.

Actual Result

The actual e-mails look like:

You have been invited to become an emergency contact for Stephan Windmüller.
If you do not wish to become an emergency contact for Stephan Windmüller, you can safely ignore this email.

and

This email is to notify you that you have been confirmed as an emergency access contact for Stephan Windmüller.

Screenshots or Videos

No response

Additional Context

No response

Build Version

2024.9.2

Environment

Cloud (bitwarden.com)

Environment Details

No response

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of C#Understanding of HTML encoding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate how email templates are rendered in Bitwarden server. The issue indicates that names are being HTML entity encoded (e.g., ü for ü) but should be displayed as actual characters. Check the email template generation code, likely in the Core project, to see if names are double encoded or if the template uses wrong encoding method. Look at files like `SendEmergencyAccessInviteEmail.cs` or similar. Ensure that the email content uses proper encoding for the email format (plain text vs HTML).