bitwarden/server

"Create Account" Button should be inactive/hidden when "globalSettings__disableUserRegistration=true"

Open

#1,268 opened on Apr 11, 2021

View on GitHub
 (11 comments) (6 reactions) (1 assignee)C# (18,588 stars) (1,575 forks)batch import
enhancementgood first issue

Description

Hi everyone,

The topic is not entirely new and an attempt has already been made to address it with issue #631 . Unfortunately the task was closed.

But I would still be of the opinion that it would make sense to deactivate the "Create Account" button and hide it as soon as the config option globalSettings__disableUserRegistration is set to "true".

At the moment it is possible to enter all data including email, username and password and only on submitting the register form user gets an error toast. This is somehow unnecessary and also arouses false expectations among users

Contributor guide

Tech stack
csharphtmlcss
Domain
frontendauthentication
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#HTMLCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how the config option 'globalSettings disableUserRegistration' is used in the server code. Look for the registration view or controller that renders the 'Create Account' button. Check the previous attempt #631 for context. The change likely involves conditionally hiding the button in the view based on the config value.
"Create Account" Button should be inactive/hidden when "globalSettings__disableUserRegistration=true" · bitwarden/server#1268 | Good First Issue