bitwalker/timex_ecto

Expand test suite

Open

#20 opened on Apr 12, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Elixir (68 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (163 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The current test suite contains a single test for Timex.Ecto.Time.cast/1 when the input is a string. Other tests are likely needed here:

  • Timex.Ecto.Time.cast/1 when input is binary
  • Timex.Ecto.Time.cast/1when input is a timestamp
  • Timex.Ecto.Time.cast/1 when input is a map like %{"calendar" => . . . }
  • Timex.Ecto.Time.cast/1 when input is time
  • Timex.Ecto.Time.load/1
  • Timex.Ecto.Time.dump/1
  • Timex.Ecto.DateTime.cast/1 functions here
  • Timex.Ecto.DateTimeWithTimezone .cast/1, .dump/1, .load/1 functions here
  • Timex.Ecto.Date functions here

I'm happy to put up a PR for these and others that you might think are necessary!

Contributor guide

Research direction
Write tests for the listed cast/load/dump functions following the pattern in the existing test file.
Tech stack
elixir
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ElixirEcto
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60