Timex.Duration.parse!/2 ignores parser argument

Open Beginner friendly
#795 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
elixir
Domain
backend

Research direction

Start by locating Timex.Duration.parse!/2 and comparing its call to parse/1 with the parse/2 interface described in the issue. Add coverage for passing a custom parser, then run the relevant project tests and confirm that parse!/2 uses the supplied parser.

Written by the indexing model from the issue text.

Description

Timex.Duration.parse!/2 is calling parse/1 instead of parse/2, which ignores the parser argument.

Dominant language
Elixir
Stars
1.8k
Forks
408
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from bitwalker/timex

All issues in bitwalker/timex

Similar issues

More Elixir issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.