bitovi/funcunit

invalid usage of delete operator

Open

#246 opened on May 29, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (395 forks)batch import
bughelp wantedp2

Repository metrics

Stars
 (575 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

There is usage of the delete operator in the method add (browser/queue.js). This construction is not valid in the strict mode so it leads to fail when FuncUnit is imported as a ES6 module.

add = function(handler, error, context) {
  if(handler instanceof Function) {
    if(typeof error === 'object') {
      context = error;
      delete error;
    }

    error = (error && error.toString()) || 'Custom method has failed.';

Found in the npm version 3.7.0

Contributor guide

Research direction
Replace the 'delete error' with 'error = undefined' or remove the assignment altogether, but ensure that the error variable is properly set before use.
Tech stack
javascript
Domain
frontendtesting
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85