bitovi/funcunit

Lint all the files

Open

#238 opened on Apr 10, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (575 stars) (395 forks)batch import
cleanuphelp wanted

Description

Right now only files in the browser/adapters/ folder are being linted: https://github.com/bitovi/funcunit/blob/c29154f65487c1dfeb474183028ae7edced3c5be/package.json#L34

That glob should be expanded to something like: *.js browser/*.js browser/**/*.js

There are a bunch of linting errors in the browser/*.js files, so those will need to be fixed.

Contributor guide

Tech stack
javascript
Domain
developer experiencetooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
knowledge of JavaScriptfamiliarity with ESLint configbasic command line
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
First, locate the glob in package.json at line 34 (referenced in the issue). Change it to `*.js browser/*.js browser/**/*.js` to cover all files. Then run the linter (e.g., `npm run lint`) to see the errors in `browser/*.js` files. Fix each error following the project's linting rules. Verify that the linter passes after fixes.