bitovi/funcunit

Lint all the files

Open

#238 opened on Apr 10, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (395 forks)batch import
cleanuphelp wanted

Repository metrics

Stars
 (575 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Right now only files in the browser/adapters/ folder are being linted: https://github.com/bitovi/funcunit/blob/c29154f65487c1dfeb474183028ae7edced3c5be/package.json#L34

That glob should be expanded to something like: *.js browser/*.js browser/**/*.js

There are a bunch of linting errors in the browser/*.js files, so those will need to be fixed.

Contributor guide

Research direction
Update the lint script in package.json to include all .js files, then run the linter and fix any errors in the browser directory.
Tech stack
javascript
Domain
testing
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptnpmESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70