bitovi/funcunit

F.open() doesn't throw when violating same-origin

Open

#156 opened on Aug 11, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (575 stars) (395 forks)batch import
bughelp wantedp3

Description

You can't, for example, load google.com from localhost. This fails, but does so silently.

We do catch the error in a try/catch here. We could improve this by checking the error in the catch and if it is a SecurityError, rethrow so the user can see the error.

Chrome and Firefox give a different error message, so detecting this might be tricky.

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptunderstanding of same origin policy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue points to the catch block in browser/open.js at line 274. To fix, inspect the caught error object inside catch. In Chrome, SecurityError has name 'SecurityError'; in Firefox, it may have different properties. Use error.name or error.code to detect security violations. Once detected, rethrow the error so the user sees it. Test with a same origin violation scenario (e.g., loading google.com from localhost). No linked PRs or comments exist, so implementation is straightforward.