bitovi/funcunit

F.open() doesn't throw when violating same-origin

Open

#156 opened on Aug 11, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (395 forks)batch import
bughelp wantedp3

Repository metrics

Stars
 (575 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

You can't, for example, load google.com from localhost. This fails, but does so silently.

We do catch the error in a try/catch here. We could improve this by checking the error in the catch and if it is a SecurityError, rethrow so the user can see the error.

Chrome and Firefox give a different error message, so detecting this might be tricky.

Contributor guide

Research direction
Examine the catch block in browser/open.js at line 274. Check if the error is a SecurityError and, if so, rethrow it so the user sees the error. Be aware that Chrome and Firefox use different error messages for same origin violations.
Tech stack
javascript
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75