bitovi/funcunit

Dynamic iframes are considered not loaded

Open

#139 opened on Feb 24, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (395 forks)batch import
bughelp wantedp2

Repository metrics

Stars
 (575 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If I create an <iframe>, populate it dynamically, and set it as the context for FuncUnit like this:

var iframe = $(document.createElement('iframe'));
iframe.contents().find('body').append(frag);    
F.open(win);

All tests will fail because FuncUnit.documentLoaded() will return false here: https://github.com/bitovi/funcunit/blob/01f767b1e95737a7dfcae1f67a75b4d72408ba37/browser/getters.js#L509

Due to the fact that FuncUnit.win.location.href === 'about:blank' here: https://github.com/bitovi/funcunit/blob/92fd4b283388576922506fb76096902c8f9183bf/browser/open.js#L258-L260

To get around this I had to overwrite FuncUnit.documentLoaded to always return true like this:

F.documentLoaded = function () { return true; };

Contributor guide

Research direction
Investigate how FuncUnit.documentLoaded() determines if the page is loaded and modify the condition to handle dynamic iframes with 'about:blank' href. Trace the code from the open.js and getters.js files to understand the flow.
Tech stack
javascript
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75