bitovi/funcunit

Typing at the start of input inside an Iframe causes cursor to reset to end

Open

#137 opened on Feb 10, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (575 stars) (395 forks)batch import
bughelp wantedp2

Description

When i try to type into a text input that already has text in it while the cursor is positioned at the start it resets it to the end of the input.

I have already located a fix for this, it seems it's using the document var instead of the h.getWindow(el) helper function.

var h = syn.helpers, getSelection = function (el) {
    var real, r, start;
    if (el.selectionStart !== undefined) {
        if (document.activeElement && document.activeElement !== el && el.selectionStart === el.selectionEnd && el.selectionStart === 0) {
            return {

Should be

var h = syn.helpers, getSelection = function (el) {
    var real, r, start;
    if (el.selectionStart !== undefined) {
        if (h.getWindow(el).document.activeElement && h.getWindow(el).document.activeElement !== el && el.selectionStart === el.selectionEnd && el.selectionStart === 0) {
            return {

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The bug is in the `getSelection` function. The fix is to replace `document.activeElement` with `h.getWindow(el).document.activeElement` to correctly reference the iframe's document. The exact change is provided in the issue body. No other changes are needed.