bitnami/sealed-secrets

Configurable template delimeters

Open

#584 opened on May 11, 2021

View on GitHubContributor guide
 (9 comments) (4 reactions) (0 assignees)Go (771 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (9,222 stars)
PR merge metrics
 (PR metrics pending)

Description

First of all, thank you so much for this project and for adding https://github.com/bitnami-labs/sealed-secrets/pull/580 in the latest release! This allowed me to remove my dependency on ConfigMapSecret and use only SealedSecrets instead!

I do have one issue with configuration files that contain golang-based templates (mainly alertmanager configuration like this one). Would it be possible to either use non-default delimiters for injecting secret into larger config? Or maybe it would be possible to allow configuring delimiters and allowing something different than the default {{ and }}?

Just to note, there is an option for this in the standard library: https://golang.org/pkg/text/template/#Template.Delims

Contributor guide

Research direction
Review the existing code for template handling and implement configurable delimiters using the text/template package's Delims method.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75