bitnami/sealed-secrets

Add namespace selector as scope

Open

#479 opened on Nov 27, 2020

View on GitHubContributor guide
 (7 comments) (14 reactions) (0 assignees)Go (771 forks)auto 404
backlogenhancementgood first issue

Repository metrics

Stars
 (9,222 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently there're are 3 scopes how a Sealed Secret can be encrypted:

  • strict
  • namespace
  • cluster-wide

We're maintaining a multi-tenant cluster and users are asking how they can reuse an existing Sealed Secret for a different namespace without encrypting again or make them cluster-wide.

A possible approach would be to support encryption of Sealed Secrets using a namespace selector as each tenant has its own set of labels on their namespaces.

Something like:

kubeseal --scope namespace-selector --selector owner=team1 -oyaml < secret.yaml > sealedsecret.yaml

The Sealed Secrets controller would only decrypt the Sealed Secret if the corresponding namespace has the label owner set to team1.

What are your thoughts about adding namespace selector as scope? Is this a feature which we might add?

Contributor guide

Research direction
Examine how existing scopes (strict, namespace, cluster wide) are implemented in the sealed secrets controller and CLI source code. Understand the encryption/decryption flow and how the scope is checked. Then design a new scope that uses label selectors on namespaces to allow decryption. Pay attention to how the scope is stored in the SealedSecret object and how it's validated during decryption. Consider the kubeseal CLI changes needed to accept the new flag scope namespace selector and a selector flag. Also consider backwards compatibility and testing.
Tech stack
go
Domain
backendinfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoKubernetes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25