bitcoindevkit/bdk_wallet

Feerate should be returned from Transaction construction

Open

#187 opened on Jan 11, 2022

View on GitHub
 (9 comments) (2 reactions) (0 assignees)Rust (94 forks)auto 404
good first issuenew feature

Repository metrics

Stars
 (54 stars)
PR merge metrics
 (PR metrics pending)

Description

When you get TransactionDetails from tx_builder.finish() it has the fee for the overall transaction but does not include the feerate of the resulting transaction. There is no simple way for the caller to replicate this information since the transaction does not have witness data at this point. This is annoying because after constructing the psbt the user should know the feerate before signing it.

This can either be done by returning another value from builder.finish() or by adding a (perhaps optional) field to TransactionDetails.

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.