Remove "wallet" field from `WalletConfigInner`

Open Beginner friendly
#332 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
rust
Domain
cli

Research direction

Search for the WalletConfigInner definition and the list wallet command or its output path. Confirm how the wallet field is serialized and how the top-level dictionary identifier supplies the name. Done means the redundant field is no longer present while the list wallet output remains correctly keyed by wallet name.

Written by the indexing model from the issue text.

Description

enhancement

Describe the enhancement
WalletConfigInner contains the wallet field which contains the wallet name. But the config is also indexed by the wallet's name, and the output of the list wallet command is something like:

{
   "wallet_name": {
      "wallet": "wallet_name",
      ...
   }
   ...
}

I think wallet can be removed in favor of the dictionary string identifier at the top level.

Dominant language
Rust
Stars
142
Forks
99
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from bitcoindevkit/bdk-cli

All issues in bitcoindevkit/bdk-cli

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.