[FEAT] - figure out if test_bitcoin conditional should check for Darwin
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 38/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- shell
- Domain
- build-system
Research direction
Start at the packageinstall step containing the TARGET_KERNEL, TARGET_ARCHITECTURE, and is_arm64_test_bitcoin_signed conditional. Check which platforms the signing path currently covers and whether the Darwin guard matches the intended package behavior. Done means the conditional signs only the appropriate packages and the existing package-install checks still pass.
Written by the indexing model from the issue text.
Description
Describe the Problem
it's like this in the packageinstall step:
if [ "${TARGET_KERNEL}" = 'Darwin' ] && [ "${TARGET_ARCHITECTURE}" = 'arm64' ] &&
! is_arm64_test_bitcoin_signed "${target_bitcoin_version}"; then
Describe the Solution
See if we should also only sign packages if it's Darwin
Optional Additional Details
No response
- Dominant language
- Shell
- Stars
- 7
- Forks
- 0
- Avg merge
- 2h 38m
- Merged PRs (30d)
- 30
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from bitcoin-tools/nodebuilder
-
feature
Difficulty 3/5 1-2 days Newbie friendliness 20/100
bitcoin-tools/nodebuilder#2588 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
bitcoin-tools/nodebuilder#2587 ·
-
feature
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
bitcoin-tools/nodebuilder#2580 ·
-
feature
Difficulty 4/5 3-5 days Newbie friendliness 15/100
bitcoin-tools/nodebuilder#2578 ·
-
feature
Difficulty 4/5 3-5 days Newbie friendliness 45/100
bitcoin-tools/nodebuilder#2552 ·
All issues in bitcoin-tools/nodebuilder
Similar issues
-
good-start
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
VilnaCRM-Org/user-service#497 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
conda-forge/spacy-feedstock#177 ·
-
area:jail bug security severity:low track:open-source
Difficulty 1/5 Under an hour Newbie friendliness 75/100