bisq-network/bisq

Trade Step 1: If BSQ chosen for trade fees while "Synchronizing DAO", show correct warning popup

Open

#5,522 opened on May 22, 2021

View on GitHub
 (2 comments) (2 reactions) (0 assignees)Java (4,505 stars) (1,292 forks)batch import
good first issuein:guiin:trade-process

Description

Description

Some BSQ users are not aware that their BSQ wallet balance is virtually zero when Bisq is "Synchronizing DAO".

They may try to pay with BSQ for trade fees, but the UI tells them they have insufficient funds, which is incorrect.

Version

v1.6.4

Steps to reproduce

Try to take or create a trade and choose to pay the fee with BSQ. Do this at a point when "Synchronizing DAO" is happening (shown in the bottom bar).

Expected behaviour

When pressing Next, the user should get a warning popup saying:

Your BSQ wallet is disabled while DAO is synchronizing and your BSQ balance may appear to be zero during this period. Please check the status bar and try again later when Synchronizing DAO is complete, or continue now with this trade and use BTC to pay the trade fees.

Actual behaviour

When pressing Next, the user gets a warning popup saying "You need more BSQ to do this transaction", which is incorrect.

Screenshots

Contributor guide

Tech stack
java
Domain
backendblockchain
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaBisq architectureDAO synchronization
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue involves modifying the trade process to check if the DAO is synchronizing when the user selects BSQ for trade fees. The warning popup currently shows 'You need more BSQ' instead of explaining that BSQ balance is unavailable during sync. Investigate the code around trade fee payment (e.g., Bisq's TradeManager or related UI components) to find where the insufficient balance check occurs. Then, add a condition to detect DAO synchronization status (likely via a service or state listener) and display the appropriate warning. Look at the linked screenshots and existing comments for context.