bisq-network/bisq

Standardize columns across all sections in Portfolio section in Bisq

Open

#5,309 opened on Mar 15, 2021

View on GitHub
 (18 comments) (2 reactions) (1 assignee)Java (4,505 stars) (1,292 forks)batch import
a:featuregood first issuein:gui

Description

Description

The columns providing trade info in the portfolio section in Bisq are not standardized. Some sections provide more details than others. This means some sections are missing information that would be useful.

The Portfolio section in Bisq consists of the following sub sections:

  • My Open Offers
  • Open Trades
  • History
  • Failed

All sub sections should have the following columns:

  • Trade ID
  • Date/Time
  • Market
  • Price
  • Deviation
  • Amount in BTC
  • Amount
  • Transaction fee
  • Trade Free
  • Payment method
  • My Role
  • Buyer deposit
  • Seller deposit
  • Offer type
  • Status

Currently, for example, it is difficult to work out what the deviation from market price was for a Trade that is in your 'Open Trades' this makes the following difficult:

  • Working out profit/loss
  • Suggesting intended outcomes to mediators
  • Suggesting intended outcomes to arbitrators
  • Placing a similar offer into the market at the same price

Also all the information above should be included in the 'Trade ID' window when clicking on the (i) for more information

My Open Offers also is the only section with 'Trigger price'. I think this is fine to stay like this.

Also all sections should have an option to export to CSV. It is only 'Open trades' missing this. This would be helpful when wanting to place the same offers again whilst they are still 'open'. Currently this has to be done by copying down the trade data manually.

Version

v1.5.9

Steps to reproduce

Look at portfolio section. Information columns are different.

Expected behaviour

Portfolio section should be consistent with the Information columns.

Screenshots

my open offers My open offers

open trades Open trades

history History

Failed Failed

Contributor guide

Tech stack
java
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaJavaFXUnderstanding of Bisq portfolio sections
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the current implementation of portfolio views in the bisq desktop module. The affected views are likely in packages like 'bisq.desktop.main.portfolio.openoffers', 'opentrades', 'history', 'failed'. Check the existing column definitions in each view (e.g., MyOpenOffersView, OpenTradesView, HistoryView, FailedView). The issue also requests CSV export for Open Trades; look for existing export functionality in other sections to reuse. Review issue comments for any additional details or maintainer guidance. No linked PRs or assignee activity noted, so the issue remains open and unsolved.