bisq-network/bisq

Use localised number formats for transaction details

Open

#3,145 opened on Aug 27, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Java (4,505 stars) (1,292 forks)batch import
good first issuein:guiin:i18n

Description

When an offer is confirmed by both sides and you get the bank account , identifier for the transaction and the rest of the necessary payment details, the amount of money to pay is written with a "." as separator. In some parts of the world we dont use a dot but a "," to tell dollars and cents, euro and cents etc apart. If you copy & paste one version into your online banking website you either get errors or you might paste a bit too much because of 1.000 could also mean one thousand and not just plain simply exactly one .

Would be nice if that part of bisq would be locale dependent too.

Contributor guide

Tech stack
java
Domain
frontendbackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java basicsUnderstanding of localization
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue requests locale dependent number formatting in transaction details. Currently, amounts use a dot as decimal separator. The goal is to use Java's NumberFormat to format numbers based on user locale. Look at the UI code that displays transaction amounts (likely in the offer confirmation or payment details view). Check if there is existing localization infrastructure in the project. A common approach is to use `NumberFormat.getNumberInstance(locale)` to format the amount. The solution should be localized and not affect other parts of the system. Maintainers may have additional comments or preferences in the issue thread.