bisq-network/bisq

[UI/UX] Alert against or prohibit the export/import of BSQ altcoin accounts

Open

#3,130 opened on Aug 23, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (4,505 stars) (1,292 forks)batch import
good first issuein:guire:usability

Description

There are some misconceptions about the workings of the BSQ and its wallet inside Bisq and it can lead to the lost of funds. This is one of them. Prompted by this thread

When moving to a new directory or starting on an entirely different computer, Bisq allows you to export/import your National Currency and Altcoin accounts. And BSQ falls under Altcoin accounts. When using a new BTC wallet, importing the previous BSQ Altcoin account will cause you to send funds to an address of the previous wallet, that you may or may have not kept. Importing your BSQ account isn't an issue when you pretend to restore the previous BTC wallet but it should also be discouraged as it promotes address reuse.

Fortunately, there's no trade limits on Altcoin accounts based on Account age so there's nothing lost in discarding old BSQ Altcoin accounts.

Contributor guide

Tech stack
java
Domain
desktopsecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java basicsBisq codebase navigation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue is to add a warning or prohibition when exporting/importing BSQ altcoin accounts. Relevant files likely include the export/import UI and logic in the Bisq desktop application. Look at the existing export/import functionality for altcoin accounts. The thread linked suggests user confusion; consider adding a confirmation dialog warning about potential fund loss. No linked PRs or assignees, so the implementation is open.
[UI/UX] Alert against or prohibit the export/import of BSQ altcoin accounts · bisq-network/bisq#3130 | Good First Issue