bisq-network/bisq

Inconsistent current value is displayed when submitting param change proposal

Open

#2,644 opened on Apr 4, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Java (4,505 stars) (1,292 forks)batch import
good first issuein:guire:usability

Description

When submitting a proposal for changing a phase length, the current value shown is inconsistent with the value shown in the dashboard. There is a technical reason for this, but potentially confusing to the user. The last block is technically part of the phase but for the user we show it as a break and don't allow proposals as the next block for confirmation would be then outside of phase.

Submitting a param change proposal: image

Governance dashboard: image

Contributor guide

Tech stack
java
Domain
blockchainfrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaFamiliarity with Bisq governance
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Review the param change proposal form and governance dashboard UI code to understand how the current phase length value is displayed. Look for Java classes handling governance proposal submission and phase length calculation. The issue mentions a technical reason for the discrepancy, possibly related to the last block being part of the phase but shown as a break. Check comments and related code to identify the inconsistency.