biocore/empress

Save extra work of cos/sin calls

Open

#225 opened on Jun 29, 2020

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (32 forks)auto 404
good first issueperformancerefactoring

Repository metrics

Stars
 (56 stars)
PR merge metrics
 (PR metrics pending)

Description

@wasade pointed this out about this JS code -- there are 8 calls to cos or sin within this block, but we could cut this down to just 4 calls by saving the value of each call for later in the block.

From some more digging, this also impacts this JS code for drawing thick lines, as well as this python code.

Contributor guide

Research direction
Locate the three code blocks mentioned (empress.js lines 404-420, 643-655, and tree.py lines 437-449). Identify repeated cos/sin calls on the same angle and replace them with a single computed variable, reusing the value. For example, compute cos(angle) once and assign to a variable, then use that variable multiple times.
Tech stack
javascriptpython
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptPythonbasic trigonometry
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65