Patterns / Modal Dialog documentation page has errors
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- javascript
- Domain
- documentation
Research direction
Open the Patterns / Modal Dialog documentation page and inspect the shown
hyperscript, starting with the reported tokenizer error in https://hyperscript.org/js/_hyperscript.js at line 13, column 0. Correct the example so the unterminated-string error is gone, then reload the page and confirm the console error no longer appears.Written by the indexing model from the issue text.
Description
The modal dialog pattern page has an error
hyperscript errors were found on the following element:
<dialog _="
on input from <input,textarea/> in me set :dirty to true
<p>on closeRequested
if :dirty
if confirm('Discard unsaved changes?')
set :dirty to false then close me
end
else
close me
end</p>
<p>on click[target is me] send closeRequested to me
on cancel halt the event then send closeRequested to me
">
<div class=" modal-header"="" open="">
<h3>Edit Contact</h3>
<button _="on click send closeRequested to closest <dialog/>" data-hyperscript-powered="true">×</button>
</dialog>
"
"
"Unterminated string at [Line: 13, Column: 0]"
"#consumeString@https://hyperscript.org/js/_hyperscript.js:551:24
#tokenize@https://hyperscript.org/js/_hyperscript.js:602:48
#initElement@https://hyperscript.org/js/_hyperscript.js:2799:46
@https://hyperscript.org/js/_hyperscript.js:2888:28
forEach@https://hyperscript.org/js/_hyperscript.js:2558:15
processNode@https://hyperscript.org/js/_hyperscript.js:2887:21
@https://hyperscript.org/js/_hyperscript.js:10392:29"
- Dominant language
- JavaScript
- Stars
- 3.8k
- Forks
- 171
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from bigskysoftware/_hyperscript
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
bigskysoftware/_hyperscript#688 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
bigskysoftware/_hyperscript#678 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
bigskysoftware/_hyperscript#695 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
bigskysoftware/_hyperscript#687 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
bigskysoftware/_hyperscript#685 ·
All issues in bigskysoftware/_hyperscript
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
curriculum documentation quality
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
githubnext/gh-aw-workshop#3897 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
agent/quality hive/hosted-available-lke648397-260827-5n31 quality testing
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
Maintainers usually reply within 1 day