beyond-all-reason/Beyond-All-Reason

commando attack range got faulty when corcom dgun got changed

Open

#3,377 opened on Jul 12, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Lua (3,922 stars) (592 forks)batch import
BugGood First IssueUnit Def

Description

Description

It now displays 2 different rings, one red outer ring that should be the default attack range and when you click 'A' you get one closer to the build range.

The detailed info (space/i) displays a range of 300 while the info panel bottom left says 279.

Attacking just inside the default circle will move commando, pretty much same behaviour that currently exists on the corcom dgun as i bug reported earlier.

Expected Behaviour

300 attack range.

Actual Behaviour

279 attack range (bit longer than buildrange).

Reproduction steps

No response

Other

No response

Contributor guide

Tech stack
lua
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the unit definitions for the commando and corcom dgun. Look for where attack range values are set (likely in Lua config files). Check the recent change to corcom dgun that introduced the bug. Examine the rendering code for attack range circles to understand why two different values (300 and 279) appear. Search for commits or comments related to this change. The bug is likely in one of the unit definition files or the GUI code that displays range indicators.