berzniz/github_pr_tree

File missing from individual commit view

Open

#130 opened on Sep 18, 2020

View on GitHub
 (5 comments) (3 reactions) (0 assignees)HTML (81 forks)batch import
bughelp wanted

Repository metrics

Stars
 (677 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Summary When I open an individual commit, at least one file is missing from the file tree. I do not know how prevalent this is, I just happened to be able to easily identify one occurrence, so I am passing that on for your consideration.

My repo is public so I can show you a good example. That screen shot is from this commit: bf2c603 (#4226)

I know that at least one more file is in this commit, components/automate-ui/src/app/pages/create-notification-modal/create-notification-modal.component.ts, because VSCode shows the changes from that specific commit:

One possible factor that may or may not be relevant: the file in question was added earlier in the commit history of this PR; that is, the PR was not just updating an existing file.

Contributor guide

Research direction
Investigate how the extension processes individual commit pages by examining the content scripts in the repository (likely in content.js or similar). Compare the list of files displayed in the tree with the actual files in the commit by inspecting the GitHub API response or DOM. Check if the file tree only considers files from the PR view but doesn't handle commits with added files correctly. Look at similar issues or comments for clues.
Tech stack
javascripthtmlcss
Domain
frontendtoolingdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Familiarity with browser extension codeUnderstanding of GitHub commit page DOMAbility to inspect network responses for commit files
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60