benoitc/gunicorn

`reload_extra_files` should accept wildcards

Open

#1,643 opened on Nov 14, 2017

View on GitHub
 (5 comments) (14 reactions) (0 assignees)Python (1,707 forks)batch import
Feature/Reloadgood first issue

Repository metrics

Stars
 (9,334 stars)
PR merge metrics
 (Avg merge 8h 8m) (1 merged PR in 30d)

Description

Hi,

My app structure is such that each view in my app has it's own config.json located at ui/<view_name>/config.json.

I would love to reload on modification for each of those JSON files.

Currently, I'm doing, for each view:

reload_extra_file = [
  'ui/<view_1>/config.json',
  'ui/<view_2>/config.json',
  'ui/<view_3>/config.json,
  ...
]

but this is a little cumbersome, since I have to add a new line everytime I add a view to my app (and I tend to forget about it).

We should support wildcards for this kind of use case, something like:

reload_extra_file = ['*.json', '*.js', '*.py', '*.yaml']

@benoitc Is that something you would consider implementing ? I can maybe help with this and create a PR if you let me know where this needs to be changed in the current code.

Contributor guide

Research direction
Examine the reload extra files feature in Gunicorn's codebase, specifically how file paths are currently matched during auto reload. Look at the 'reloader' module (gunicorn/reloader.py) to understand the existing logic. Then implement support for glob patterns using Python's glob module or fnmatch. Ensure that both exact paths and patterns (e.g., '*.json') are handled, and update any relevant tests.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70