benoitc/gunicorn

Separate instrumentation and logging

Open

#1,564 opened on Aug 6, 2017

View on GitHub
 (9 comments) (4 reactions) (0 assignees)Python (1,707 forks)batch import
Feature/LoggingImprovementhelp wanted

Repository metrics

Stars
 (9,334 stars)
PR merge metrics
 (Avg merge 8h 8m) (1 merged PR in 30d)

Description

Issues like #1405 demonstrate that having statsd instrumentation built on top of the logging handlers means instrumentation and logging are coupled. Some have found this coupling surprising.

I would like to see proposals for ways to separate these functions.

This may be as simple as making the statsd Logger into a handler instead, so it can be invoked no matter which logger is being used.

Contributor guide

Research direction
Propose a design to decouple statsd instrumentation from logging handlers, e.g., by making the statsd logger a separate handler that can be used with any logger.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50