ben-eb/perfectionist

Support CSS apply rules

Open

#12 opened on Aug 26, 2015

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (11 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (229 stars)
PR merge metrics
 (PR metrics pending)

Description

Semicolons are erroneously removed from the following:

:root {
  --toolbar-theme: {
    background-color: hsl(120, 70%, 95%);
    border-radius: 4px;
    border: 1px solid var(--theme-color late);
  };
  --toolbar-title-theme: {
    color: green;
  };
}

http://tabatkins.github.io/specs/css-apply-rule/

Contributor guide

Research direction
Look at the CSS parser code to identify where semicolons inside custom property blocks are being removed. Focus on how the tool handles nested blocks and semicolons in ' var: { ... };' syntax.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CSSCSS custom properties
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65