beetbox/beets

ImportFeeds: fix/disable/catch symlink usage on windows

Open

#840 opened on Jun 22, 2014

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (12,133 stars) (1,837 forks)batch import
buggood first issueimportfeedswindows

Description

... because it doesnt work?

but it seems possible: http://en.wikipedia.org/wiki/NTFS_symbolic_link http://lifehacker.com/5496652/how-to-use-symlinks-in-windows

Traceback (most recent call last):
  File "C:\Python27\Scripts\beet-script.py", line 9, in <module>
    load_entry_point('beets==1.3.6', 'console_scripts', 'beet')()
  File "C:\Python27\lib\site-packages\beets\ui\__init__.py", line 967, in main
    _raw_main(args)
  File "C:\Python27\lib\site-packages\beets\ui\__init__.py", line 958, in _raw_m
ain
    subcommand.func(lib, suboptions, subargs)
  File "C:\Python27\lib\site-packages\beets\ui\commands.py", line 816, in import
_func
    import_files(lib, paths, query)
  File "C:\Python27\lib\site-packages\beets\ui\commands.py", line 788, in import
_files
    session.run()
  File "C:\Python27\lib\site-packages\beets\importer.py", line 262, in run
    pl.run_parallel(QUEUE_SIZE)
  File "C:\Python27\lib\site-packages\beets\util\pipeline.py", line 345, in run
    self.coro.send(msg)
  File "C:\Python27\lib\site-packages\beets\util\pipeline.py", line 158, in coro

    task = func(*(args + (task,)))
  File "C:\Python27\lib\site-packages\beets\importer.py", line 1076, in manipula
te_files
    task.finalize(session)
  File "C:\Python27\lib\site-packages\beets\importer.py", line 395, in finalize
    self._emit_imported(session.lib)
  File "C:\Python27\lib\site-packages\beets\importer.py", line 427, in _emit_imp
orted
    plugins.send('album_imported', lib=lib, album=self.album)
  File "C:\Python27\lib\site-packages\beets\plugins.py", line 379, in send
    handler(**args)
  File "C:\Python27\lib\site-packages\beetsplug\importfeeds.py", line 138, in al
bum_imported
    _record_items(lib, album.album, album.items())
  File "C:\Python27\lib\site-packages\beetsplug\importfeeds.py", line 127, in _r
ecord_items
    os.symlink(syspath(path), syspath(dest))
AttributeError: 'module' object has no attribute 'symlink'

Contributor guide

Tech stack
python
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic PythonUnderstanding of os moduleWindows environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate whether os.symlink is available on Windows in Python 2.7 (it is not). Implement a fallback: either copy the file instead of symlink, or use a conditional based on os.name. See the ImportFeeds plugin file at beetsplug/importfeeds.py, around line 127. Consider adding a try except for AttributeError or using sys.platform to skip symlink on Windows. Also check if there are any existing discussions in the issue comments about preferred solution.