bee-san/RustScan

Add ARM support for GitHub actions

Open

#683 opened on Nov 4, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (19,268 stars) (1,284 forks)batch import
good first issue

Description

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#runner-context

We should add arm support to our github actions.

here's one comment about it:

 FYI, I did start looking at this:
  1. adding the appropriate build to the matrix and setting cross: true works perfectly!
  2. …but then the Python tests fail for that step only.
  3. it looks like actions-rs/toolchain is now deprecated and equally, it's not clear what the de facto standard Action might be.

So the build isn't too tricky but getting it working in a pipeline is proving a little more rabbit-hole-y than expected.

Originally posted by @PsypherPunk in https://github.com/RustScan/RustScan/issues/579#issuecomment-2107504881

Contributor guide

Tech stack
rustgithub actions
Domain
ci cd
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
GitHub Actions basicsRust cross compilation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate adding ARM runners to the GitHub Actions matrix. Review the comment in #579 about setting 'cross: true' and the Python test failures. Explore alternatives to the deprecated actions rs/toolchain, such as dtolnay/rust toolchain or the official setup rust. Determine the root cause of the Python test failures for ARM builds and propose a solution. Reference the issue body and linked comment for context.