beautifier/js-beautify

HTML option "wrap-attributes": "preserve" does not preserve line break before closing angle bracket

Open

#1,707 opened on Sep 10, 2019

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (8,342 stars) (1,460 forks)batch import
good first issuelanguage: htmltype: bug

Description

If you use "wrap-attributes": "force-expand-multiline", you get:

<tag
    attr1="val1"
    attr2="val2"
>content</tag>

The line break before the closing angle bracket is forced with this option.

Now, when you set "wrap-attributes": "preserve", I would expect this formatting to be preserved. However, you get:

<tag
    attr1="val1"
    attr2="val2">content</tag>

Please fix "preserved" or add a new option for keeping the line break before the closing angle bracket.

Contributor guide

Tech stack
javascripthtmlcss
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptjs beautify internalsHTML parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the HTML beautifier code in js beautify, likely in `js/lib/beautify html.js`, to understand how 'wrap attributes' options are handled. Look for the logic that distinguishes 'force expand multiline' from 'preserve' regarding line breaks before closing angle brackets. Consider adding a new option or modifying the preserve behavior to retain the line break. Check existing tests in the `test` directory for related test cases.