bdlukaa/native_admob_flutter

Native AdTextView font

Open

#76 opened on Jun 11, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Dart (57 forks)github user discovery
Native Adenhancementgood first issuehelp wanted

Repository metrics

Stars
 (81 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi! Thank you for creating and maintaining this lib :) (I ran into some issues with google_mobile_ads and switched to this. This was way easier to set up and the ads just worked 🎉 The way to design the layout is a lot more fun to use too even if it's not using Flutter widgets! Anyway...)

It seems currently the font of a TextStyle is not passed on to the native TextView:

https://github.com/bdlukaa/native_admob_flutter/blob/536e1c89581c4a16bf9d2680ab4d2ab5ed5989eb/android/src/main/kotlin/com/bruno/native_admob_flutter/native/NativeAd.kt#L329-L341

It would be nice if I could customize the font to match the look of the rest of my app.

Contributor guide

Research direction
Examine the native Android code in NativeAd.kt around line 329-341 to see how font is currently handled. Implement passing the TextStyle font family to the native TextView's setTypeface method.
Tech stack
dartflutterkotlin
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
FlutterAndroid development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60