bcherny/undux

Should Undux forward refs to wrapped components?

Open

#75 opened on Dec 19, 2018

View on GitHub
 (4 comments) (1 reaction) (0 assignees)TypeScript (33 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (1,551 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I think it would be handy if Undux used React.forwardRef() to make sure that any refs attached to components created using withStore got attached to the wrapped component instead of the wrapper itself. Thoughts?

Contributor guide

Research direction
Implement React.forwardRef in the withStore HOC to forward refs to wrapped components.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65