bcherny/json-schema-to-typescript

Schema type inference should take `format` into account

Open

#528 opened on Jun 1, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (449 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (3,302 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I'm not sure if support for the ipv6 format was implemented or if it was intended to be implemented, but using a string prop with an anyOf [{format: 'hostname'}, {format: 'ipv6'}], the result is string and {[key: string]: unknown}, where hostname converts to string.

ipv6 should also convert to string.

ref: https://github.com/appium/appium/pull/18690

Contributor guide

Research direction
Examine how the `hostname` format is handled in the codebase and add similar handling for `ipv6` format.
Tech stack
typescript
Domain
devtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75