bcherny/json-schema-to-typescript

$merge in schema produces empty typescript interface

Open

#282 opened on Mar 16, 2020

View on GitHub
 (4 comments) (1 reaction) (0 assignees)TypeScript (449 forks)github user discovery
help wantedin discussion

Repository metrics

Stars
 (3,302 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I have a json schema using keyword $merge (to merge two subschemas, where allof fails due to the 'additionalProperties=false' issue). Passing it through the json-schema-to-typescript gives an empty interface.

Contributor guide

Research direction
Investigate the json schema to typescript source code to understand how $merge is handled. Check the test files for existing $merge cases and trace the logic that processes schema merging to find where the empty interface is generated.
Tech stack
typescript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JSON SchemaTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60