bcherny/json-schema-to-typescript

Allow unicode characters in type name

Open

#279 opened on Mar 4, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)TypeScript (449 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (3,302 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://github.com/bcherny/json-schema-to-typescript/blob/d898361ff973d3746ea695f1efce75c975061c6f/src/utils.ts#L164

The member of type name is restricted to only english letters (and some symbol) Typescript now allows unicode characters (doc link)

So, modify this function to allow unicode characters in type name, or as an option?

Contributor guide

Research direction
Modify the regular expression in src/utils.ts to allow Unicode letters (using the Unicode property escape \p{L}) for type names, ensuring compatibility with TypeScript's identifier rules.
Tech stack
typescript
Domain
toolingbackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptJSON Schemaregular expressions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70