bcherny/json-schema-to-typescript

cli: --style.singleQuote false throws a type error

Open

#199 opened on Nov 9, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (449 forks)github user discovery
bugcligood first issuehelp wanted

Repository metrics

Stars
 (3,302 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

running json2ts --style.singleQuote false will throw

Error: Invalid `"singleQuote"` value. Expected a boolean, but received `"false"`.

Contributor guide

Research direction
Inspect the command line argument parsing for style.singleQuote; ensure that the boolean value false is parsed as a boolean instead of a string.
Tech stack
typescriptnodejs
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75