bcherny/format-as-currency

Fix for Custom Currency Symbol

Open

#28 opened on Jun 8, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (23 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (32 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi,

This is not an Issue but a possible fix for a possible issue 😄

In my Angular App i've got a customizable currency symbol and i use a real time database (Firebase).

In your function 'toFloat' from 'formatAsCurrencyUtilities' you provide a solutions only for Dollar Symbol with the RegEx on line 53.

To Avoid error from this i replaced that line with:

    var matchString = 0;
    if (currencyString) matchString = currencyString.match(/(\d|\.)/g).join('');
    return parseFloat(matchString, 10);

With this you can user any filter, with any currency.

Contributor guide

Research direction
Replace the regex in toFloat to handle any currency symbol by matching only digits and the decimal point.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90