A11y: Modal close "button" should be keyboard focusable
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- accessibility, frontend
Research direction
Start by locating the modal integration and reviewing the existing Escape-key behavior described in this issue. Check the linked vex upstream pull request and issue discussion before choosing a workaround. Done means the modal’s close control can receive keyboard focus while retaining its current close behavior.
Written by the indexing model from the issue text.
Description
We can't focus the "x" close button via keyboard:
We can still close the modal via escape key: https://github.com/bbcmicrobit/PythonEditor/pull/310
We could fix this via workaround, or if the modal library get's a fix upstream: https://github.com/HubSpot/vex/pull/134
More info in https://github.com/bbcmicrobit/PythonEditor/issues/347#issuecomment-728986198
- Dominant language
- JavaScript
- Stars
- 201
- Forks
- 126
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from bbcmicrobit/PythonEditor
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
bbcmicrobit/PythonEditor#406 ·
-
U Open
Difficulty 5/5 Over a week Newbie friendliness 1/100
bbcmicrobit/PythonEditor#405 ·
-
Difficulty 5/5 Over a week Newbie friendliness 10/100
bbcmicrobit/PythonEditor#391 · 2 comments · 6 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
bbcmicrobit/PythonEditor#375 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
bbcmicrobit/PythonEditor#367 ·
All issues in bbcmicrobit/PythonEditor
Similar issues
-
bug customer-eng Durable Agents Inngest status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
githubnext/gh-aw-cao#13475 ·
-
[BUG]: "Clear All" in Settings doesn't clear the saved analysis, old data comes back after reload Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
AOSSIE-Org/OrgExplorer#253 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
oxc-project/oxc#26944 ·
-
ai-observability bug team/ai-observability
Difficulty 2/5 1-3 hours Newbie friendliness 78/100