Support None values

Nobody has claimed this yet.

Start by reading the Bool, Collection, DefaultInfo, DepsetFile, Dict, File, Int, Label, Runfiles, Str, Struct, and Target subject implementations, noting any existing None handling. Begin with basic assertions for a None actual value and None passed to equals() and not_equals(); done means the supported subjects handle these cases consistently.

Written by the indexing model from the issue text.

Support for None is very spotty. I think IntSubject supports it, maybe string, but not all of them. None doesn't happen much in rule code per-se, more so in utility functions. It's common enough that not having this makes using rules_testing a bit of a pain.

So implement allowing a None as the actual value and having None passed to equals() and not_equals(). Basic support should be pretty easy (i.e. just asserting None on a None value). Handling a None actual value for all the other assertions might be more involved -- almost all of them assume they are working with a non-None value. We can start with basic and go from there, though.

Subjects to update:

Bool
Collection
DefaultInfo
DepsetFile
Dict
File
Int
Label
Runfiles
Str
Struct
Target

Assessment

Research direction

Description

Contributor guide

First steps

More from bazelbuild/rules_testing

Similar issues