Fix return type for JavaInfo.getSourceJars()

Open
#333 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
build-system

Research direction

Start by locating JavaInfo.getSourceJars() and the related JavaSkylarkApiProvider API. Compare its current SkylarkList return type with the prior NestedSet type and the other collection-returning methods, then inspect existing uses before deciding what cleanup is in scope. Done means the API type is corrected and affected uses remain consistent.

Written by the indexing model from the issue text.

Description

P2

getSourceJars() returns SkylarkList now.

Should be NestedSet as was before in JavaSkylarkApiProvider and to be consistent with other methods which returns collection of Jar files.

Also consider some cleaning in scope of this task, as this method can be already used by someone.

Dominant language
Starlark
Stars
103
Forks
102
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from bazelbuild/rules_java

All issues in bazelbuild/rules_java

Similar issues

More Build System issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.