iOS example failing using Bazel version 1.1.0

Open
#130 0 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
ios

Research direction

Start with the iOS tutorial and ios-app/BUILD, then reproduce bazel build //ios-app:ios-app using the reported Bazel version and the deprecated-attribute flag. Compare the example's objc_library and apple_binary attributes with the current rules, and consider the work done when the documented command builds successfully with supported attributes.

Written by the indexing model from the issue text.

Description

Hello,

Using Bazel version 1.1.0 installed using Homebrew and following the steps on the documentation https://docs.bazel.build/versions/master/tutorial/ios-app.html, I got the following error trying to build the iOS project :

➜  tutorial git:(source-only) ✗ bazel build //ios-app:ios-app

INFO: Writing tracer profile to '/private/var/tmp/_bazel_mmosbah/50a095adb6c59f331d9d5d198a21d596/command.profile.gz'
ERROR: /private/var/tmp/_bazel_mmosbah/50a095adb6c59f331d9d5d198a21d596/external/build_bazel_rules_apple/apple/bundling/entitlements.bzl:300:25: Traceback (most recent call last):
	File "/private/var/tmp/_bazel_mmosbah/50a095adb6c59f331d9d5d198a21d596/external/build_bazel_rules_apple/apple/bundling/entitlements.bzl", line 294
		rule(<3 more arguments>)
	File "/private/var/tmp/_bazel_mmosbah/50a095adb6c59f331d9d5d198a21d596/external/build_bazel_rules_apple/apple/bundling/entitlements.bzl", line 300, in rule
		attr.label(<2 more arguments>)
'single_file' is no longer supported. use allow_single_file instead. You can use --incompatible_disable_deprecated_attr_params=false to temporarily disable this check.
ERROR: Skipping '//ios-app:ios-app': error loading package 'ios-app': in /private/var/tmp/_bazel_mmosbah/50a095adb6c59f331d9d5d198a21d596/external/build_bazel_rules_apple/apple/ios.bzl: in /private/var/tmp/_bazel_mmosbah/50a095adb6c59f331d9d5d198a21d596/external/build_bazel_rules_apple/apple/bundling/binary_support.bzl: Extension file 'apple/bundling/entitlements.bzl' has errors
WARNING: Target pattern parsing failed.
ERROR: error loading package 'ios-app': in /private/var/tmp/_bazel_mmosbah/50a095adb6c59f331d9d5d198a21d596/external/build_bazel_rules_apple/apple/ios.bzl: in /private/var/tmp/_bazel_mmosbah/50a095adb6c59f331d9d5d198a21d596/external/build_bazel_rules_apple/apple/bundling/binary_support.bzl: Extension file 'apple/bundling/entitlements.bzl' has errors
INFO: Elapsed time: 0.163s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (1 packages loaded)

With --incompatible_disable_deprecated_attr_params=false I'm getting another error :

➜  tutorial git:(source-only) ✗ bazel build --incompatible_disable_deprecated_attr_params=false //ios-app:ios-app

INFO: Writing tracer profile to '/private/var/tmp/_bazel_mmosbah/50a095adb6c59f331d9d5d198a21d596/command.profile.gz'
ERROR: /Users/user_name/examples/tutorial/ios-app/BUILD:2:1: //ios-app:UrlGetClasses: no such attribute 'xibs' in 'objc_library' rule
ERROR: /Users/user_name/examples/tutorial/ios-app/BUILD:13:1: //ios-app:ios-app.apple_binary: no such attribute 'non_propagated_deps' in 'apple_binary' rule
ERROR: error loading package 'ios-app': Package 'ios-app' contains errors
INFO: Elapsed time: 0.156s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (1 packages loaded)

If i understand correctly the example project is not up to date with the latest version ?
What's the new equivalent of non_propagated_deps ?

Thanks !

Dominant language
Starlark
Stars
957
Forks
578
Avg merge
2d 10h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from bazelbuild/examples

All issues in bazelbuild/examples

Similar issues

More Build System issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.