bazelbuild/bazel

@bazel_tools//tools/sh:local_sh_toolchain is missing any constraints to make it local

Open

#21,932 opened on Apr 9, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (4,465 forks)batch import
P2help wantedteam-Configurabilityteam-ExternalDepstype: feature request

Repository metrics

Stars
 (25,384 stars)
PR merge metrics
 (Avg merge 22d 20h) (77 merged PRs in 30d)

Description

@bazel_tools//tools/sh:sh_configure is a repo rule that detects and configures sh_toolchain (path to bash), by querying the local host.

The guts of the generated repo rule are: https://github.com/bazelbuild/bazel/blob/0f760395e04cb0accb912be128b4f363663e8d30/tools/sh/sh_configure.bzl#L59-L69

I think this needs at least exec_compatible_with = HOST_CONSTRAINTS or else this path will incorrectly be used on other exec platforms. (HOST_CONSTRAINTS isn't specific enough, but it's the best we've got.)

Contributor guide

Research direction
Investigate how to add `exec compatible with` to the sh toolchain generated by sh configure. Look at existing toolchain definitions in Bazel's repository for examples of HOST CONSTRAINTS usage.
Tech stack
java
Domain
build systemdevops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
BazelStarlarkGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60