bazelbuild/bazel

Add `textual_hdrs` to cc_binary

Open

#20,823 opened on Jan 9, 2024

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Java (4,465 forks)batch import
P2help wantedteam-Rules-CPPtype: feature request

Repository metrics

Stars
 (25,384 stars)
PR merge metrics
 (Avg merge 22d 20h) (77 merged PRs in 30d)

Description

Description of the feature request:

Given that there is an allowlist of possible file extensions in hdrs= and that cc_binary doesn't have a textual_hdrs attribute, there isn't really a good way to say "this cc_binary has a source file that is included from somewhere but it doesn't compile by itself".

Sounds like a logical addition and nice polish.

Which category does this issue belong to?

C++/Objective-C Rules

What underlying problem are you trying to solve with this feature?

No response

Which operating system are you running Bazel on?

\

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

Contributor guide

Research direction
Investigate the existing implementation of textual hdrs for cc library and adapt it for cc binary. Understand the cc binary rule definition in Bazel's C++ rules and add the textual hdrs attribute accordingly.
Tech stack
cpp
Domain
build system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Bazel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30