bazelbuild/bazel

Support repository_ctx.patch(patch_directory) arg

Open

#19,772 opened on Oct 9, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (4,465 forks)batch import
P3help wantedteam-ExternalDepstype: feature request

Repository metrics

Stars
 (25,384 stars)
PR merge metrics
 (Avg merge 22d 20h) (77 merged PRs in 30d)

Description

Description of the feature request:

I would like to specify the working directory for the repository_ctx.patch so that it is different than the repository root.

Aspect's bazel-lib has a similar function: https://github.com/aspect-build/bazel-lib/blob/8b06f31c46bea4e416bd199f67da68f8494a2ebd/docs/repo_utils.md?plain=1#L33

Which category does this issue belong to?

Core

What underlying problem are you trying to solve with this feature?

Having patching restricted to a subset of the repository tree.

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

Contributor guide

Research direction
Examine the current implementation of repository ctx.patch in the Bazel source code to understand how patches are applied, then add support for an optional patch directory argument to specify a working directory other than the repository root.
Tech stack
java
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Bazel build systemStarlark API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40