bazelbuild/bazel

Better bash-less Windows support in actions.run_shell: add command_bat, command_ps

Open

#15,194 opened on Apr 7, 2022

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (4,465 forks)batch import
P3good first issuehelp wantedteam-Rules-APItype: feature request

Repository metrics

Stars
 (25,384 stars)
PR merge metrics
 (Avg merge 22d 20h) (77 merged PRs in 30d)

Description

Description of the feature request:

For better bash-less Windows support,ctx.actions.run_shell could add command_bat (with the same behavior as genrule's cmd_bat) and command_ps (with the same behavior as genrule's cmd_ps).

This would, in particular, considerably simplify skylib's Windows support, where currently we are forced to write and execute temporary .bat files on Windows (and attempt to deal with the ancient terror of argument quoting in .bat interpreter context - take a look at https://stackoverflow.com/questions/4094699/how-does-the-windows-command-interpreter-cmd-exe-parse-scripts if you don't mind losing some points of sanity).

Pinging potentially interested parties: @brandjon @meteorcloudy @alexeagle

Contributor guide

Research direction
Examine the implementation of actions.run shell and genrule's cmd bat/cmd ps. Identify where to add new parameters and update the related code paths. Check existing tests for Windows support.
Tech stack
javashell
Domain
build system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaBazel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65